Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude glob not working #8

Open
mavendonovanhubbard opened this issue Aug 10, 2023 · 1 comment · May be fixed by #9
Open

Exclude glob not working #8

mavendonovanhubbard opened this issue Aug 10, 2023 · 1 comment · May be fixed by #9

Comments

@mavendonovanhubbard
Copy link

mavendonovanhubbard commented Aug 10, 2023 •
edited
Loading

I'm trying to test everything under spec/**/*_spec.rb while excluding tests under ``spec/selenium/*_spec.rb`. I've tried various different exclude glob patterns but none of them seem to be working. The files I want excluded are always included.

Here is my action

- uses: chaosaffe/split-tests@4f1ca766cb93923ca216e02f1aefed20944e313f
  id: split-tests
  name: Split tests
  with:
    glob: spec/**/*_spec.rb
    split-total: ${{ env.rspec-runners }}
    split-index: ${{ matrix.rspec_index }}
    exclude-glob: spec/selenium/**/*_spec.rb
    line-count: true

Some of the other patterns I've tried.

  • "*selenium*"
  • spec/selenium/services_spec.rb
@ninjapanzer ninjapanzer linked a pull request Jul 9, 2024 that will close this issue
Open
@skolsuper
Copy link

Same here. I downloaded the split_tests binary from the latest Github release, the same way the script does, and verified that it worked as expected. However, I could only test the split_tests.darwin.gz (macOS) release so there may be some issue with the linux binary, although it seems unlikely. The fix in #9 (removing single quotes) was not necessary to make the command work correctly. I am at a loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude Glob doesn't exclude ninjapanzer/split-tests
2 participants
@skolsuper @mavendonovanhubbard