Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1042 Allow configure db ConnMaxLifetime & ConnMaxIdleTime #1207

Closed
wants to merge 17 commits into from
Closed

feat: #1042 Allow configure db ConnMaxLifetime & ConnMaxIdleTime #1207

wants to merge 17 commits into from

Conversation

jeswinsimon
Copy link

@jeswinsimon jeswinsimon commented Mar 24, 2024 •
edited by Thegaram
Loading

Purpose or design rationale of this PR

Allow connMaxLifetime and connMaxIdleTime to be configured for database connections.

Fixed #1042.

feat: #1042 Allow configure db ConnMaxLifetime & ConnMaxIdleTime

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@jeswinsimon jeswinsimon mentioned this pull request Mar 24, 2024
Closed
13 tasks
@jeswinsimon
Copy link
Author

@HAOYUatHZ Please review.

@jeswinsimon jeswinsimon mentioned this pull request Mar 24, 2024
Open
@jeswinsimon jeswinsimon force-pushed the feat/issue-1042_config branch from 4238c9a to 2228b41 Compare March 25, 2024 17:15
0xmountaintop
0xmountaintop reviewed Apr 1, 2024
View reviewed changes
common/database/db.go Outdated Show resolved Hide resolved
0xmountaintop
0xmountaintop reviewed Apr 1, 2024
View reviewed changes
common/database/db.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 56.39%. Comparing base (d7a5723) to head (6ef367b).

❗ Current head 6ef367b differs from pull request most recent head 43aaa65. Consider uploading reports for the commit 43aaa65 to get more accurate results

Files Patch % Lines
common/database/db.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1207      +/-   ##
===========================================
+ Coverage    56.11%   56.39%   +0.28%     
===========================================
  Files          156      158       +2     
  Lines        12131    12293     +162     
===========================================
+ Hits          6807     6933     +126     
- Misses        4798     4820      +22     
- Partials       526      540      +14
Flag Coverage Δ
bridge-history-api 72.50% <ø> (ø)
common 61.85% <50.00%> (-0.27%) ⬇️
coordinator 19.23% <ø> (-0.71%) ⬇️
rollup 63.17% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xmountaintop
Copy link
Contributor

CI fails

@jeswinsimon
Copy link
Author

CI fails

Resolved.

@0xmountaintop
Copy link
Contributor

hi @jeswinsimon the CI fails again. can you fix them? so that we can merge it soon

@georgehao
Copy link
Member

This pr hasn't been updated in a long time, close it. if necessary, pls reopen it

@georgehao georgehao closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flukena Flukena Flukena left review comments

@0xmountaintop 0xmountaintop 0xmountaintop left review comments

Assignees

@0xmountaintop 0xmountaintop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow configure db ConnMaxLifetime & ConnMaxIdleTime
4 participants
@jeswinsimon @0xmountaintop @georgehao @Flukena