Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte_Representation gadget may lead to vk change against each assignment #31

Open
noel2004 opened this issue Apr 14, 2023 · 1 comment

Comments

@noel2004
Copy link
Member

In Byte_Representation gadget, the selector (a fixed col) is enabled while assigning byte represents:

self.selector.enable(region, offset);

It should be supposed that we have diffferent counts on assigned bytes for synctheis base on the witness. That is, the circuit (vk and pk) would change with changing on witness and the test vk_validity would expect to fail

@z2trillion
Copy link
Contributor

Yes, this is problem now. I plan to solve this by padding this gadget (and all other gadgets) with default assignments to a fixed length.

For this gadget, assigning 0 to every advice column should satisfy the constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants