-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devirgo style on phase 1 #83
Conversation
f445826
to
220e0d4
Compare
TODO: use |
48107f3
to
0b47beb
Compare
Done by disable |
gkr/src/prover/phase1.rs
Outdated
|
||
// sumcheck: sigma = \sum_y( \sum_j f1^{(j)}(y) * g1^{(j)}(y)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this sigma = \sum_y( f1(y) * (\sum_j g1^{(j)}(y)))
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more precisely, should be sigma = \sum_{t || y}(f1({t || y}) * (\sum_j g1^{(j)}({t || y})))
fixed in latest commit ad4a6d8
6b1bcd1
to
ad4a6d8
Compare
instruction add example with prove/verify
ad4a6d8
to
e843bf1
Compare
* devirgo style on phase 1 instruction add example with prove/verify * optimize sumcheck algo * fix comment
* devirgo style on phase 1 instruction add example with prove/verify * optimize sumcheck algo * fix comment
optimisation type
Change Scope
phase-1
two steps into single step and applied similar tricks to move parallism, refer to prev work phase-2benchmark results on evm add 1
EVM add
throughput improvement can be up to 20xbenchmark results on keccak 256 1
keccak throughput improve on low instances and remain the same on high instances
Footnotes
AMD EPYC 9R14 (16 phy cores) + 32GB memory ↩ ↩2