Use ToExpr trait instead of ad-hoc expr functions
#736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| impl<F: SmallField, E: ExtensionField<BaseField = F>> ToExpr<E> for F { |
There was a problem hiding this comment.
This implementation of the trait is a bit problematic, because it clashes with making implementations for eg u64.
ceno_zkvm/src/expression.rs
Outdated
|
|
||
| // Implement From trait for u128 separately since it requires explicit reduction |
There was a problem hiding this comment.
We never actually used this implementation anywhere.
matthiasgoergens
added a commit
that referenced
this pull request
Dec 12, 2024
Extracted from #736 for ease of review.
10to4
pushed a commit
to 10to4/ceno
that referenced
this pull request
Dec 12, 2024
…#737) Extracted from scroll-tech#736 for ease of review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.