Remove broken features non_pow2_rayon_thread and riv64
#723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature `non_pow2_rayon_thread` was not tested: even just turning it on caused compiler errors.
matthiasgoergens
requested review from
hero78119,
kunxian-xia and
naure
and removed request for
hero78119
roylou
approved these changes
Dec 12, 2024
Well, they can’t have been used, because if you enable any of them, you get compiler errors. :) |
matthiasgoergens
deleted the
matthias/remove-broken-non_pow2_rayon_thread
branch
10to4
pushed a commit
to 10to4/ceno
that referenced
this pull request
Dec 12, 2024
…ch#723) Features `non_pow2_rayon_thread` and `riv64` are not tested: we can't even compile with them. Because `riv64` is gone, we can make `riv32` invisible: it's effects are now just the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
non_pow2_rayon_threadandriv64are not tested: we can't even compile with them.Because
riv64is gone, we can makeriv32invisible: it's effects are now just the default.