hide-fast-decode: rename and privatize specialized instruction form #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naure
force-pushed
the
hide-fast-decode
branch
from
6f3bfa0 to
ec3b5eb
Compare
kunxian-xia
approved these changes
Sep 12, 2024
hero78119
pushed a commit
that referenced
this pull request
Sep 30, 2024
…212) _Follow-up to #188 The above PR started to depend on a special internal type, originally and confusingly named `Instruction`. This PR uses the intended public type `DecodedInstruction` and makes the weird one private. Co-authored-by: Aurélien Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #188.
The above PR started to depend on a special internal type, originally and confusingly named
Instruction.This PR uses the intended public type
DecodedInstructionand makes the weird one private.