Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecall/halt #125

Closed
Tracked by #95
kunxian-xia opened this issue Aug 14, 2024 · 1 comment · Fixed by #258
Closed
Tracked by #95

ecall/halt #125

kunxian-xia opened this issue Aug 14, 2024 · 1 comment · Fixed by #258
Assignees
@kunxian-xia

Comments

@kunxian-xia
Copy link
Collaborator

kunxian-xia commented Aug 14, 2024 •
edited by hero78119
Loading

some random notes

  • once halt, then all the following opcode sequence will be halts

  • questions: do we need to add pc < MAX_PC to all opcode circuit to assure pc value always within range?
@kunxian-xia kunxian-xia mentioned this issue Aug 14, 2024
Open
93 tasks
@kunxian-xia kunxian-xia moved this to Todo in Ceno - Base VM Aug 15, 2024
@kunxian-xia kunxian-xia self-assigned this Sep 11, 2024
@kunxian-xia kunxian-xia linked a pull request Sep 19, 2024 that will close this issue
complete e2e sound in integration test #251
Merged
@kunxian-xia kunxian-xia removed a link to a pull request Sep 19, 2024
complete e2e sound in integration test #251
Merged
@hero78119 hero78119 mentioned this issue Sep 24, 2024
Merged
@kunxian-xia kunxian-xia linked a pull request Sep 24, 2024 that will close this issue
Feat: Ecall/Halt #258
Merged
3 tasks
@kunxian-xia kunxian-xia mentioned this issue Sep 24, 2024
Merged
3 tasks
@naure
Copy link
Collaborator

naure commented Sep 25, 2024

do we need to add pc < MAX_PC

Every instruction circuit must look up pc in the program table, which contains only valid pc.

@github-project-automation github-project-automation bot moved this from Todo to Done in Ceno - Base VM Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kunxian-xia kunxian-xia

Labels
None yet
Projects
Ceno - Base VM
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Ecall/Halt scroll-tech/ceno
2 participants
@kunxian-xia @naure