Skip to content

Commit

Permalink
fix comment
Browse files Browse the repository at this point in the history
  • Loading branch information
hero78119 committed Jul 15, 2024
1 parent 220ebc1 commit e843bf1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions gkr/src/prover/phase1.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use crate::{

// Prove the items copied from the current layer to later layers for data parallel circuits.
impl<E: ExtensionField> IOPProverState<E> {
/// Sumcheck 1: sigma = \sum_{t || y} \sum_j ( f1^{(j)}(t || y) * g1^{(j)}(t || y) )
/// Sumcheck 1: sigma = \sum_{t || y}(f1({t || y}) * (\sum_j g1^{(j)}({t || y})))
/// sigma = \sum_j( \alpha^j * subset[i][j](rt_j || ry_j) )
/// f1^{(j)}(y) = layers[i](t || y)
/// g1^{(j)}(y) = \alpha^j * eq(rt_j, t) * eq(ry_j, y)
Expand Down Expand Up @@ -149,7 +149,7 @@ impl<E: ExtensionField> IOPProverState<E> {
};
exit_span!(span);

// sumcheck: sigma = \sum_y( \sum_j f1^{(j)}(y) * g1^{(j)}(y))
// sumcheck: sigma = \sum_{s || y}(f1({s || y}) * (\sum_j g1^{(j)}({s || y})))
let span = entered_span!("virtual_poly");
let mut virtual_poly_1 = VirtualPolynomial::new_from_mle(f1, E::BaseField::ONE);
virtual_poly_1.mul_by_mle(g1, E::BaseField::ONE);
Expand Down
2 changes: 1 addition & 1 deletion gkr/src/verifier/phase1.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ impl<E: ExtensionField> IOPVerifierState<E> {
acc + point_and_eval.eval * alpha_pow
});

// Sumcheck: sigma = \sum_{t || y}( \sum_j f1^{(j)}( t || y) * g1^{(j)}(t || y) )
// Sumcheck: sigma = \sum_{t || y}(f1({t || y}) * (\sum_j g1^{(j)}({t || y})))
// f1^{(j)}(y) = layers[i](t || y)
// g1^{(j)}(t || y) = \alpha^j * eq(rt_j, t) * eq(ry_j, y)
// g1^{(j)}(t || y) = \alpha^j * eq(rt_j, t) * copy_to[j](ry_j, y)
Expand Down
4 changes: 2 additions & 2 deletions multilinear_extensions/src/mle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ impl<E: ExtensionField> DenseMultilinearExtension<E> {
let nv = self.num_vars;
// evaluate single variable of partial point from left to right
for (i, point) in partial_point.iter().enumerate() {

Check warning on line 149 in multilinear_extensions/src/mle.rs

View workflow job for this annotation

GitHub Actions / Run Tests

unused variable: `i`
// override buf[b1, b2,..bt, 0] = (1-point) * buf[b1, b2,..bt, 0] + point * buf[b1,b2,..bt, 1] in parallel
// override buf[b1, b2,..bt, 0] = (1-point) * buf[b1, b2,..bt, 0] + point * buf[b1, b2,..bt, 1] in parallel
match &mut self.evaluations {
FieldType::Base(evaluations) => {
let evaluations_ext = evaluations
Expand Down Expand Up @@ -444,7 +444,7 @@ impl<E: ExtensionField> DenseMultilinearExtension<E> {
// evaluate single variable of partial point from left to right
for (i, point) in partial_point.iter().enumerate() {
let max_log2_size = nv - i;
// override buf[b1, b2,..bt, 0] = (1-point) * buf[b1, b2,..bt, 0] + point * buf[b1,b2,..bt, 1] in parallel
// override buf[b1, b2,..bt, 0] = (1-point) * buf[b1, b2,..bt, 0] + point * buf[b1, b2,..bt, 1] in parallel
match &mut self.evaluations {
FieldType::Base(evaluations) => {
let evaluations_ext = evaluations
Expand Down

0 comments on commit e843bf1

Please sign in to comment.