Skip to content

Commit

Permalink
Remove redundant format Make targets (#724)
Browse files Browse the repository at this point in the history
Just use `cargo fmt` or `cargo fmt --all` for the same effect.

Especially the `fmt` target was obsolote: why would you want to format
specifically only `ceno_zkvm`?
  • Loading branch information
matthiasgoergens authored Dec 10, 2024
1 parent 33901fd commit c4e729a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lints.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
run: |
cargo make --version || cargo install cargo-make
- name: Check code format
run: cargo make fmt-all-check
run: cargo fmt --all --check

- name: Run clippy
env:
Expand Down
15 changes: 0 additions & 15 deletions Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,26 +33,11 @@ args = [
command = "cargo"
workspace = false

[tasks.fmt-all-check]
args = ["fmt", "--all", "--", "--check"]
command = "cargo"
workspace = false

[tasks.fmt-all]
args = ["fmt", "--all"]
command = "cargo"
workspace = false

[tasks.clippy-all]
args = ["clippy", "--all-features", "--all-targets", "--", "-D", "warnings"]
command = "cargo"
workspace = false

[tasks.fmt]
args = ["fmt", "-p", "ceno_zkvm", "--", "--check"]
command = "cargo"
workspace = false

[tasks.riscv_stats]
args = ["run", "--bin", "riscv_stats"]
command = "cargo"
Expand Down

0 comments on commit c4e729a

Please sign in to comment.