Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SJR Website to GitHub Actions #360

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Move SJR Website to GitHub Actions #360

merged 3 commits into from
Oct 6, 2023

Conversation

delasare
Copy link
Contributor

@delasare delasare commented Oct 3, 2023

Resolves

  • Updates CODEOWNERS flle
  • Adds Github Actions workflow file
  • Removes CirclCI Config

Ron de las Alas added 2 commits September 28, 2023 15:15
@delasare delasare requested review from a team and cwillisf and removed request for a team October 3, 2023 20:17
@delasare delasare changed the title Rd/move sjr website to gha Move SJR Website to GitHub Actions Oct 3, 2023
cwillisf
cwillisf requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, but otherwise it looks good

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@cwillisf
Update .github/workflows/deploy.yml
1399274 
Co-authored-by: Christopher Willis-Ford <[email protected]>
@delasare delasare requested a review from cwillisf October 5, 2023 20:52
@delasare delasare merged commit ab05a21 into develop Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwillisf cwillisf cwillisf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delasare @cwillisf