Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise scotty-0.20's lower version bounds on base #324

Closed
RyanGlScott opened this issue Oct 3, 2023 · 2 comments
Closed

Raise scotty-0.20's lower version bounds on base #324

RyanGlScott opened this issue Oct 3, 2023 · 2 comments
Assignees
Labels

Comments

@RyanGlScott
Copy link
Contributor

As discovered in this CI job, cabal can pick a build plan with scotty-0.20 and GHC 8.4, even though 8.4 doesn't support building scotty-0.20:

Failed to build scotty-0.20.
Build log ( /github/home/.cabal/logs/ghc-8.4.4/scotty-0.20-6d4ed606ddf8cc6e1fb58b8a4a4553c26e357584de0804cc06b6bd01dcc3e932.log ):
Configuring library for scotty-0.20..
Preprocessing library for scotty-0.20..
Building library for scotty-0.20..

Web/Scotty/Internal/Types.hs:5:14: error:
    Unsupported extension: DerivingVia
  |
5 | {-# language DerivingVia #-}
  |              ^^^^^^^^^^^

Can you raise scotty-0.20's lower version bounds on base to >=4.12 to reflect this? Actually, it might even be worth raising it to >=4.14, since this PR indicates that only GHC 8.10 and later are officially supported.

@ocramz ocramz added the easy fix label Oct 3, 2023
@ocramz
Copy link
Collaborator

ocramz commented Oct 3, 2023

Ah yes, I added DerivingVia because I wanted to autoderive the Alternative instance of ActionT via Ap but I ended up writing the instance by hand. Sorry!

@ocramz ocramz self-assigned this Oct 3, 2023
@ocramz
Copy link
Collaborator

ocramz commented Oct 3, 2023

I've made a revision to scotty-0.20, now base >= 4.14 .

@ocramz ocramz closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants