feat: Add option to turn off setup of shell completion #342
+49
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcrockett
changed the title
mmcrockett
changed the title
ghthor
approved these changes
Dec 13, 2024
Comment on lines
+50
to
+65
| if [ "$git_skip_shell_completion" != "yes" ]; then | ||
| __define_git_completion () { | ||
| eval " | ||
| _git_$1_shortcut () { | ||
| COMP_LINE=\"git $2 \${COMP_LINE/$1 }\" | ||
| let COMP_POINT+=$((4+${#2}-${#1})) | ||
| COMP_WORDS=(git $2 \"\${COMP_WORDS[@]:1}\") | ||
| let COMP_CWORD+=1 | ||
|
|
||
| local cur words cword prev | ||
| _get_comp_words_by_ref -n =: cur words cword prev | ||
| __git_wrap__git_main | ||
| } | ||
| " | ||
| } | ||
| fi |
There was a problem hiding this comment.
Because this is already an eval hidden behind a function definition, I would prefer not placing this in an if condition. The calling of this function is already behind the new setting that you added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Screenshot of errors I see:
Proposed Fix
git_skip_shell_completionthat is backward compatible and will ignore any shell completion setup