Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT - Strata in COX model #247

Open
hermanhmchan opened this issue May 11, 2024 · 3 comments
Open

FEAT - Strata in COX model #247

hermanhmchan opened this issue May 11, 2024 · 3 comments

Comments

@hermanhmchan
Copy link

Description of the feature

Can you support strata in COX model? It is included in lifetimes and statsmodels.

Additional context

https://lifelines.readthedocs.io/en/latest/fitters/regression/CoxPHFitter.html
https://www.statsmodels.org/stable/generated/statsmodels.duration.hazard_regression.PHReg.predict.html#statsmodels.duration.hazard_regression.PHReg.predict

@QB3
Copy link
Collaborator

QB3 commented May 12, 2024

Hello @hermanhmchan ,
Thanks a lot for your interest!
Could you tell us more about how important/useful this option is in your community? (maybe @Klopfe or @PABannier knows).
Would you be able to start a PR to implement this feature?

@agramfort
Copy link
Member

agramfort commented May 12, 2024 via email

@QB3
Copy link
Collaborator

QB3 commented May 12, 2024

We currently implement a Cox model.
I was wondering how important is the strata option: it seems to be some kind of group weight for the Cox datafit. If this is the case, this might be not too hard to implement since the Cox datafit already has a weighting option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants