Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add developer.md #266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

APN-Pucky
Copy link
Member

Closes: #177

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (d4231f5) to head (e9a414e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files           2        2           
  Lines         320      320           
  Branches       64       64           
=======================================
  Hits          294      294           
  Misses         17       17           
  Partials        9        9           
Flag Coverage Δ
unittests-3.10 91.87% <ø> (ø)
unittests-3.11 91.87% <ø> (ø)
unittests-3.12 91.87% <ø> (ø)
unittests-3.13 91.87% <ø> (ø)
unittests-3.8 91.87% <ø> (ø)
unittests-3.9 91.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@APN-Pucky
Copy link
Member Author

APN-Pucky commented Oct 18, 2024

@matthewfeickert I am trying to create a 0.9.1 version and I followed your video, but https://github.com/scikit-hep/pylhe/actions/runs/11403842254/job/31731751820#step:8:46 here "Bump version" fails with

fatal: Failed to resolve 'v0.9.1^{}' as a valid ref.

Further I still need to figure out conda after pypi.

@APN-Pucky
Copy link
Member Author

@matthewfeickert @eduardo-rodrigues Can one of you help with releasing pylhe 0.9.1?

@eduardo-rodrigues
Copy link
Member

It is best that @matthewfeickert helps as I have not released here so far. I tend to do my releases a different way. Can you help out @matthewfeickert?

Aside - this PR isn't done, right? Maybe better have this "admin" doc under the docs directory?

@matthewfeickert
Copy link
Member

I am trying to create a 0.9.1 version and I followed your video, but https://github.com/scikit-hep/pylhe/actions/runs/11403842254/job/31731751820#step:8:46 here "Bump version" fails with

fatal: Failed to resolve 'v0.9.1^{}' as a valid ref.

Further I still need to figure out conda after pypi.

@APN-Pucky Sorry, I've been pretty distracted (feel free to poke me on email/Slack if I'm not responsive on GitHub as my notifications can become just a wall sometimes). Can you tell me where you're hitting this specifically in the release workflow?

@matthewfeickert
Copy link
Member

matthewfeickert commented Nov 5, 2024

I fixed @APN-Pucky not having publishing permissions in PR #269, but I also went ahead and released v0.9.1 which is now on PyPI.

Further I still need to figure out conda after pypi.

@APN-Pucky the good news is that there really isn't anything to figure out. Conda-forge automatically watches PyPI for new releases and will generate a new release PR to https://github.com/conda-forge/pylhe-feedstock for us in a few hours. We then just review it to make sure there are no dependency changes and then we can merge it and conda-forge will then do all the building and publishing automatically.

@APN-Pucky APN-Pucky marked this pull request as ready for review November 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write developer.md to explain maintainers process
3 participants