Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https://pyhf.readthedocs.io/en/v to linkcheck_ignore #2029

Closed
matthewfeickert opened this issue Sep 24, 2022 · 0 comments · Fixed by #2031
Closed

Add https://pyhf.readthedocs.io/en/v to linkcheck_ignore #2029

matthewfeickert opened this issue Sep 24, 2022 · 0 comments · Fixed by #2031
Assignees
Labels
bug Something isn't working docs Documentation related

Comments

@matthewfeickert
Copy link
Member

During release will get

(             faq: line   13) broken    https://pyhf.readthedocs.io/ - 404 Client Error: Not Found for url: https://pyhf.readthedocs.io/en/v0.7.0/

As that doesn't exist yet. So should add it to

pyhf/docs/conf.py

Lines 497 to 505 in 931dd36

linkcheck_ignore = [
'cli.html#pyhf-xml2json',
# https://doi.org/10.31526/lhep.2020.158 is causing linkcheck connection timeouts in CI
r'https://doi\.org/10\.31526/.*',
# https://doi.org/10.1051/epjconf/x DOI URLs will periodically generate 500 Server Error
r'https://doi\.org/10\.1051/epjconf/.*',
# tags for a release won't exist until it is made, but the release notes need to reference them
r'https://github.com/scikit-hep/pyhf/releases/tag/.*',
]

like we did with https://github.com/scikit-hep/pyhf/releases/tag/.* in PR #1705.

@matthewfeickert matthewfeickert added bug Something isn't working docs Documentation related labels Sep 24, 2022
@matthewfeickert matthewfeickert self-assigned this Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant