From 9842e824712fcf02d42e49aa07016ea40139f70c Mon Sep 17 00:00:00 2001
From: Giordon Stark <kratsg@gmail.com>
Date: Mon, 29 Aug 2022 09:36:21 -0400
Subject: [PATCH] docs: Add typehint aliases (#1969)

* Use Sphinx autodoc typehint aliases to improve readability of documentation.
   - c.f. https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#confval-autodoc_type_aliases
---
 docs/conf.py                     | 30 ++++++++++++++++++++++++++++++
 src/pyhf/tensor/numpy_backend.py | 14 +++++---------
 2 files changed, 35 insertions(+), 9 deletions(-)

diff --git a/docs/conf.py b/docs/conf.py
index 81e5f1a4f1..276d85a52b 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -141,6 +141,36 @@ def setup(app):
     'tensorflow_probability',
 ]
 
+
+_type_aliases_inverted = {
+    'pyhf.typing': [
+        'PathOrStr',
+        'ParameterBase',
+        'Parameter',
+        'Measurement',
+        'ModifierBase',
+        'NormSys',
+        'NormFactor',
+        'HistoSys',
+        'StatError',
+        'ShapeSys',
+        'ShapeFactor',
+        'LumiSys',
+        'Modifier',
+        'Sample',
+        'Channel',
+        'Observation',
+        'Workspace',
+        'Literal',
+    ],
+    'numpy.typing': ['ArrayLike', 'DTypeLike', 'NBitBase', 'NDArray'],
+}
+autodoc_type_aliases = {
+    item: f'{k}.{item}' for k, v in _type_aliases_inverted.items() for item in v
+}
+
+autodoc_typehints_format = 'fully-qualified'
+
 # List of patterns, relative to source directory, that match files and
 # directories to ignore when looking for source files.
 # This patterns also effect to html_static_path and html_extra_path
diff --git a/src/pyhf/tensor/numpy_backend.py b/src/pyhf/tensor/numpy_backend.py
index 1e623d0147..ea00a3b78f 100644
--- a/src/pyhf/tensor/numpy_backend.py
+++ b/src/pyhf/tensor/numpy_backend.py
@@ -15,7 +15,7 @@
 T = TypeVar("T", bound=NBitBase)
 
 Tensor = Union["NDArray[np.number[T]]", "NDArray[np.bool_]"]
-
+FloatIntOrBool = Literal["float", "int", "bool"]
 log = logging.getLogger(__name__)
 
 
@@ -53,7 +53,7 @@ def __init__(self, **kwargs: dict[str, str]):
         self.name = 'numpy'
         self.precision = kwargs.get('precision', '64b')
         self.dtypemap: Mapping[
-            Literal['float', 'int', 'bool'],
+            FloatIntOrBool,
             DTypeLike,  # Type[np.floating[T]] | Type[np.integer[T]] | Type[np.bool_],
         ] = {
             'float': np.float64 if self.precision == '64b' else np.float32,
@@ -206,7 +206,7 @@ def isfinite(self, tensor: Tensor[T]) -> NDArray[np.bool_]:
         return np.isfinite(tensor)
 
     def astensor(
-        self, tensor_in: ArrayLike, dtype: Literal['float'] = 'float'
+        self, tensor_in: ArrayLike, dtype: FloatIntOrBool = 'float'
     ) -> ArrayLike:
         """
         Convert to a NumPy array.
@@ -247,9 +247,7 @@ def product(self, tensor_in: Tensor[T], axis: Shape | None = None) -> ArrayLike:
     def abs(self, tensor: Tensor[T]) -> ArrayLike:
         return np.abs(tensor)
 
-    def ones(
-        self, shape: Shape, dtype: Literal["float", "int", "bool"] = "float"
-    ) -> ArrayLike:
+    def ones(self, shape: Shape, dtype: FloatIntOrBool = "float") -> ArrayLike:
         try:
             dtype_obj = self.dtypemap[dtype]
         except KeyError:
@@ -261,9 +259,7 @@ def ones(
 
         return np.ones(shape, dtype=dtype_obj)
 
-    def zeros(
-        self, shape: Shape, dtype: Literal["float", "int", "bool"] = "float"
-    ) -> ArrayLike:
+    def zeros(self, shape: Shape, dtype: FloatIntOrBool = "float") -> ArrayLike:
         try:
             dtype_obj = self.dtypemap[dtype]
         except KeyError: