Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings about VariationPath overrides when none are used #486

Open
alexander-held opened this issue Aug 20, 2024 · 0 comments
Open

Warnings about VariationPath overrides when none are used #486

alexander-held opened this issue Aug 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@alexander-held
Copy link
Member

The

variation override specified, but {VariationPath} not found in default path

warning message triggers for histogram inputs even when no overrides are used at the moment.

Example test that will currently fail for test__histo_path:

# no variation path anywhere, so no warning
assert (
    collector._histo_path(
        "f.root:h1", "", {}, {}, {}, None
    )
    == "f.root:h1"
)
assert (
    "variation override specified, but {VariationPath} not found in default path"
    not in [rec.message for rec in caplog.records]
)
caplog.clear()

This needs to be fixed, presumably in templates.collector._histo_path.

@alexander-held alexander-held added the bug Something isn't working label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant