This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
scx: Cosmetic changes to kfuncs #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make __bpf_kfunc_start/end_defs() blocks strict so that they only contain kfunc definitions. - Match BTF_KFUNCS table with kfunc definition blocks so that they always come right after in the same order. - Add function comment to scx_bpf_select_cpu_dfl() and rename @found to @is_idle which is more accurate and consistent with the BPF side declaration.
Byte-Lab
approved these changes
Apr 5, 2024
Byte-Lab
reviewed
Apr 5, 2024
| * Empty function body because we aren't actually acquiring or | ||
| * releasing a reference to a global idle cpumask, which is read-only | ||
| * in the caller and is never released. The acquire / release semantics | ||
| * here are just used to make the cpumask is a trusted pointer in the |
There was a problem hiding this comment.
Noticed a grammatical typo here from a previous commit. Feel free to fix, or ignore as you prefer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make __bpf_kfunc_start/end_defs() blocks strict so that they only contain kfunc definitions.
Match BTF_KFUNCS table with kfunc definition blocks so that they always come right after in the same order.
Add function comment to scx_bpf_select_cpu_dfl() and rename @found to @is_idle which is more accurate and consistent with the BPF side declaration.