-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We have CLJS support! #56
Open
alexandergunnarson
wants to merge
8
commits into
scgilardi:release
Choose a base branch
from
alexandergunnarson:release
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 27, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 36647b6 - Browse repository at this point
Copy the full SHA 36647b6View commit details -
"Meat" of the CLJS compatibilization
- Tests do not pass yet because .clj, not .cljc
Configuration menu - View commit details
-
Copy full SHA for f1219fe - Browse repository at this point
Copy the full SHA f1219feView commit details -
- All tests now pass, both CLJ and CLJS. - However, do check the (very few) things marked “FIXME” and address them as you see fit. They involve `eval` (CLJ only), a reflection test (CLJ only), a cljs.test multimethod which is only available from CLJ, and platform-specific stack traces in CLJS. None of these things alter the functionality of Slingshot.
Configuration menu - View commit details
-
Copy full SHA for be2f408 - Browse repository at this point
Copy the full SHA be2f408View commit details -
Update .travis.yml and project.clj to support CLJS and CLJC
- In order to do this, had to drop 1.4, 1.5, 1.6 support. We keep 1.7 and 1.8 support. .cljx is an option if we need to have 1.4-1.6 support still.
Configuration menu - View commit details
-
Copy full SHA for 32011b5 - Browse repository at this point
Copy the full SHA 32011b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0290679 - Browse repository at this point
Copy the full SHA 0290679View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0db7132 - Browse repository at this point
Copy the full SHA 0db7132View commit details
Commits on Jul 28, 2016
-
Fix dependency issue with
if-cljs
andwhen-cljs
This fixes something that appeared when I tried to use the CLJS version of Slingshot in a project — namely, that slingshot.support referring to its own macro apparently sometimes causes a problem (though it doesn’t always). Thus, the offending macros have been moved to slingshot.util.
Configuration menu - View commit details
-
Copy full SHA for 9e0f171 - Browse repository at this point
Copy the full SHA 9e0f171View commit details -
Configuration menu - View commit details
-
Copy full SHA for d641e1c - Browse repository at this point
Copy the full SHA d641e1cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.