Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We have CLJS support! #56

Open
wants to merge 8 commits into
base: release
Choose a base branch
from

Commits on Jul 27, 2016

  1. Configuration menu
    Copy the full SHA
    36647b6 View commit details
    Browse the repository at this point in the history
  2. "Meat" of the CLJS compatibilization

    - Tests do not pass yet because .clj, not .cljc
    alexandergunnarson committed Jul 27, 2016
    Configuration menu
    Copy the full SHA
    f1219fe View commit details
    Browse the repository at this point in the history
  3. Rename .clj -> .cljc

    - All tests now pass, both CLJ and CLJS.
    - However, do check the (very few) things marked “FIXME” and address
    them as you see fit. They involve `eval` (CLJ only), a reflection test
    (CLJ only), a cljs.test multimethod which is only available from CLJ,
    and platform-specific stack traces in CLJS. None of these things alter
    the functionality of Slingshot.
    alexandergunnarson committed Jul 27, 2016
    Configuration menu
    Copy the full SHA
    be2f408 View commit details
    Browse the repository at this point in the history
  4. Update .travis.yml and project.clj to support CLJS and CLJC

    - In order to do this, had to drop 1.4, 1.5, 1.6 support. We keep 1.7
    and 1.8 support. .cljx is an option if we need to have 1.4-1.6 support
    still.
    alexandergunnarson committed Jul 27, 2016
    Configuration menu
    Copy the full SHA
    32011b5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0290679 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0db7132 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2016

  1. Fix dependency issue with if-cljs and when-cljs

    This fixes something that appeared when I tried to use the CLJS version
    of Slingshot in a project — namely, that slingshot.support referring to
    its own macro apparently sometimes causes a problem (though it doesn’t
    always). Thus, the offending macros have been moved to slingshot.util.
    alexandergunnarson committed Jul 28, 2016
    Configuration menu
    Copy the full SHA
    9e0f171 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d641e1c View commit details
    Browse the repository at this point in the history