Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution of scalajs:* files fails if the containing project aggregates another scalaJS project #21

Open
jmcclell opened this issue Feb 21, 2024 · 1 comment · May be fixed by #22
Open

Comments

@jmcclell
Copy link

When a project aggregates other projects, it runs the command sequentially on each of the aggregated projects and then finally on the specified project. However, in this mode, it adds a tab character to the start of each project's individual output. This means that the output for fastLinkJSOutput and fullLinkJSOutput have a tab character in front and the plugin doesn't trim it, so path resolution fails.

PR incoming.

jmcclell added a commit to jmcclell/vite-plugin-scalajs that referenced this issue Feb 21, 2024
@jmcclell jmcclell linked a pull request Feb 21, 2024 that will close this issue
@jmcclell
Copy link
Author

If anyone else runs into this before this is merged, you can disable aggregation for this particular command in your project via:

Compile / fastLinkJSOutput / aggregate := false
and
Compile / fullLinkJSOutput / aggregate := false

jmcclell added a commit to jmcclell/vite-plugin-scalajs that referenced this issue Feb 22, 2024
jmcclell added a commit to jmcclell/vite-plugin-scalajs that referenced this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant