You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having been looking at data associated with consumed amp hours, there seems to be an inconsistent use of path names.
The main SignalK Scheme defines the path "electrical.batteries.*.capacity.dischargeSinceFull" as "Cumulative discharge since battery was last full"
Therefore the data from the SignalK-venus-plugfin related to consumed amps (dbus path '/ConsumedAmphours') should be mapped to the above path, instead it is mapped at line 51 within venusToDeltas.js to electrical.batteries.${m.instanceName}.capacity.consumedCharge
The data mapped to "electrical.batteries.*.capacity.dischargeSinceFull" is actually dbus path '/History/LastDischarge', which is misleading to the SignalK path, as defined in the schema.
NOTE1: CAN data from PGN127506 (Consumed AH) should be mapped to this SignalK path, and making this change would keep everything consistent.
I also note the there are several dbus /history/ paths and maybe history should be added to all these in SignalK, to make it clear they are historical data and not current, examples are
Having been looking at data associated with consumed amp hours, there seems to be an inconsistent use of path names.
The main SignalK Scheme defines the path "electrical.batteries.*.capacity.dischargeSinceFull" as "Cumulative discharge since battery was last full"
Therefore the data from the SignalK-venus-plugfin related to consumed amps (dbus path '/ConsumedAmphours') should be mapped to the above path, instead it is mapped at line 51 within venusToDeltas.js to
electrical.batteries.${m.instanceName}.capacity.consumedCharge
The data mapped to "electrical.batteries.*.capacity.dischargeSinceFull" is actually dbus path '/History/LastDischarge', which is misleading to the SignalK path, as defined in the schema.
This seems to be in error and is misleading to the original SignalK schema (https://github.com/SignalK/specification/blob/master/schemas/groups/electrical.json lines 430-434).
Could we map as follows:
Dbus Path - SignalK Path
/ConsumedAmphours - electrical.batteries..capacity.dischargeSinceFull (NOTE 1)
//History/LastDischarge - electrical.batteries..capacity.history.lastDischargeSinceFull
NOTE1: CAN data from PGN127506 (Consumed AH) should be mapped to this SignalK path, and making this change would keep everything consistent.
I also note the there are several dbus /history/ paths and maybe history should be added to all these in SignalK, to make it clear they are historical data and not current, examples are
Happy to create a diff if required, but a fairly simple change to the venusToDeltas.js file.
Many Thanks
The text was updated successfully, but these errors were encountered: