Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Clarity styles only for internal library scope #1

Open
medjedovicm opened this issue Aug 18, 2022 · 1 comment
Open

Import Clarity styles only for internal library scope #1

medjedovicm opened this issue Aug 18, 2022 · 1 comment
Assignees
@medjedovicm

Comments

@medjedovicm
Copy link
Member

medjedovicm commented Aug 18, 2022 •
edited
Loading

Currently, if styles are imported, they take their place in the whole client app which is something we don't want since client design system choice should be flexible.

The current workaround is that styles aren't shipped with a library, instead, raw CSS is copied inside the client app, in a sasjs-ui wrapper component which has that CSS applied only for that component that wraps these library components.

One downside of this workaround is that in @sasjs/angular-seed-app font sizes are a bit smaller, tho everything seems useable.
@medjedovicm medjedovicm self-assigned this Aug 18, 2022
@medjedovicm
Copy link
Member Author

medjedovicm commented Aug 18, 2022 •
edited
Loading

@allanbowe This is not a blocker for DC since DC has already clarity styles imported globally. But it's not something that should be forgotten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@medjedovicm medjedovicm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@medjedovicm