Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide content goes up #47

Open
salutcava opened this issue Jun 21, 2016 · 2 comments
Open

Slide content goes up #47

salutcava opened this issue Jun 21, 2016 · 2 comments

Comments

@salutcava
Copy link

Hello,
When I swipe slide, the previous slide content goes up, I think this is bad for UX.
How can I prevent it to go up ?
Thanks

@cinder92
Copy link

👍 same issue here

@cinder92
Copy link

cinder92 commented Aug 25, 2016

solved by adding delegate-handle to

<ion-slide-box 
            show-pager="false"
            on-slide-changed="slideHasChanged($index)"
            delegate-handle="slider"
        >

UPDATE:

with this modification tab scroll will no work anymore, so, to solve this issue for once you need to change line 64 from tabSlideBox.js

from this

ionicScrollDelegate = ionicScrollDelegate.$getByHandle(handle);

to this

ionicScrollDelegate = ionicScrollDelegate.$getByHandle('tabScroll');

then in your template you'll need to add a delegate-handle to ion-scroll tabs like this

<div class="tsb-ic-wrp">
        <ion-scroll direction="x" class="tsb-hscroll" delegate-handle="tabScroll">
            <a href="javascript:;" 
                class="{{tab.icon}}" 
                ng-repeat="tab in home.tabs"
                ng-click="home.goTo($index)"
                ng-class="{'active' : home.currentTab == $index}"
                on-finish-render="home.test()"
            >
                {{tab.text}}
            </a>
        </ion-scroll>
    </div>

i hope it helps anyone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants