Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Notifications into a dependency #175

Open
groenroos opened this issue Apr 7, 2021 · 1 comment
Open

Extract Notifications into a dependency #175

groenroos opened this issue Apr 7, 2021 · 1 comment
Assignees
Labels
refactoring Drastic code quality improvements

Comments

@groenroos
Copy link
Member

Not every Sapling instance will necessarily need to send emails (or in the future, texts or push notifications), so making every Sapling instance install nodemailer and front-matter for that seems unnecessary.

Refactor notifications to be their own separate dependency that can be optionally installed to Sapling.

@groenroos groenroos added the refactoring Drastic code quality improvements label Apr 7, 2021
@groenroos groenroos added this to the M3 - Release 3.0 milestone Apr 7, 2021
@groenroos groenroos self-assigned this Apr 7, 2021
@groenroos
Copy link
Member Author

Open question remains on how should the built-in password reset hook function if the Notification dependency is not present - although given that it can similarly be currently nonfunctional if nodemailer hasn't been configured correctly, this may be a wider consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Drastic code quality improvements
Development

No branches or pull requests

1 participant