From 8e0df1a0d28a308fae618352e2db6d66b82d2b0e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= <sandro.jaeckel@sap.com>
Date: Thu, 22 Aug 2024 17:14:43 +0200
Subject: [PATCH] Run top level searches async

---
 src/changes.rs | 29 +++++++++++++++++++----------
 src/main.rs    | 20 ++++++++++++++------
 2 files changed, 33 insertions(+), 16 deletions(-)

diff --git a/src/changes.rs b/src/changes.rs
index 483cc56..7796d42 100644
--- a/src/changes.rs
+++ b/src/changes.rs
@@ -1,7 +1,8 @@
-use anyhow::anyhow;
+use anyhow::{anyhow, Context};
 use octocrab::models::commits::Commit;
 use octocrab::models::pulls::Review;
 use octocrab::models::pulls::ReviewState::Approved;
+use tokio::task::JoinSet;
 
 use crate::remote::Remote;
 
@@ -15,27 +16,35 @@ pub struct RepoChangeset {
 }
 
 impl RepoChangeset {
-    pub async fn analyze_commits(&mut self) -> Result<(), anyhow::Error> {
+    pub async fn analyze_commits(mut self) -> Result<Self, anyhow::Error> {
         let compare = self.remote.compare(&self.base_commit, &self.head_commit).await?;
 
-        for commit in &compare.commits {
-            self.analyze_commit(commit).await?;
+        let mut join_set = JoinSet::new();
+        for commit in compare.commits {
+            join_set.spawn(self.clone().analyze_commit(commit));
         }
 
-        Ok(())
+        while let Some(res) = join_set.join_next().await {
+            let changes = res?.context("while collecting change")?;
+            for change in changes {
+                self.changes.push(change);
+            }
+        }
+
+        Ok(self)
     }
 
-    async fn analyze_commit(&mut self, commit: &Commit) -> Result<(), anyhow::Error> {
-        let associated_prs = self.remote.associated_prs(commit).await?;
+    async fn analyze_commit(mut self, commit: Commit) -> Result<Vec<Changeset>, anyhow::Error> {
+        let change_commit = CommitMetadata::new(&commit);
 
-        let change_commit = CommitMetadata::new(commit);
+        let associated_prs = self.remote.associated_prs(&commit).await?;
         if associated_prs.is_empty() {
             self.changes.push(Changeset {
                 commits: vec![change_commit],
                 pr_link: None,
                 approvals: Vec::new(),
             });
-            return Ok(());
+            return Ok(self.changes);
         }
 
         for associated_pr in &associated_prs {
@@ -67,7 +76,7 @@ impl RepoChangeset {
             self.changes.push(changeset);
         }
 
-        Ok(())
+        Ok(self.changes)
     }
 }
 
diff --git a/src/main.rs b/src/main.rs
index b10a426..3e324f2 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -17,6 +17,7 @@ use clap::{Parser, Subcommand};
 use git2::Repository;
 use helm_config::ImageRefs;
 use remote::Remote;
+use tokio::task::JoinSet;
 use url::{Host, Url};
 
 const BOLD_UNDERLINE: Style = Style::new().bold().underline();
@@ -86,23 +87,30 @@ async fn main() -> Result<(), anyhow::Error> {
         Commands::Repo { remote } => {
             let mut remote = Remote::parse(remote)?;
             api_clients.fill(&mut remote)?;
-            let repo = &mut RepoChangeset {
+            let repo = RepoChangeset {
                 name: remote.repository.clone(),
                 remote,
                 base_commit: cli.base,
                 head_commit: cli.head,
                 changes: Vec::new(),
             };
-            repo.analyze_commits().await.context("while finding reviews")?;
-            print_changes(&[repo.clone()])?;
+            let repo = repo.analyze_commits().await.context("while finding reviews")?;
+            print_changes(&[repo])?;
         },
         Commands::HelmChart { workspace } => {
-            let mut changes =
+            let changes =
                 find_values_yaml(workspace.clone(), &cli.base, &cli.head).context("while finding values.yaml files")?;
 
-            for repo in &mut changes {
+            let mut join_set = JoinSet::new();
+            for mut repo in changes {
                 api_clients.fill(&mut repo.remote)?;
-                repo.analyze_commits().await.context("while collecting repo changes")?;
+                join_set.spawn(repo.analyze_commits());
+            }
+
+            let mut changes = Vec::new();
+            while let Some(res) = join_set.join_next().await {
+                let repo_changeset = res?.context("while collecting repo changes")?;
+                changes.push(repo_changeset);
             }
 
             print_changes(&changes)?;