You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@marcelmamula This code that was added in #829 breaks cluster configurations which are using FQDN as node names.
I am not clear why was it added as it worked fine with pacemaker before and after commenting out the code it still works fine. I didn't want to commit a removal as I'm not sure if any code that I can't test relies on it.
Basically if the defaults are not set the ha_cluster role does a good job generating the correct config based on ansible facts and provided variables.
This change introduces a regression by setting defaults which don't match ansible facts when FQDNs are used in inventory and cluster node names.
It may be possible to fix this by changing node_name: "{{ ansible_hostname }}" to node_name: "{{ inventory_name }}", but as I mention it doesn't seem like this code is needed?
The text was updated successfully, but these errors were encountered:
@rob0d This change was done to remove need to provide mandatory input, as we can default into known values.
This is why it contains task above one you linked, which uses User input variable sap_ha_pacemaker_cluster_ha_cluster that you can use as before with FQDN, and only when it is not defined and filled, it will default into code you linked.
- name: "SAP HA Prepare Pacemaker - Register sap_ha_pacemaker_cluster_ha_cluster"when:
- __sap_ha_pacemaker_cluster_ha_cluster is not defined
- sap_ha_pacemaker_cluster_ha_cluster is definedansible.builtin.set_fact:
__sap_ha_pacemaker_cluster_ha_cluster: "{{ sap_ha_pacemaker_cluster_ha_cluster }}"
@marcelmamula
This code that was added in #829 breaks cluster configurations which are using FQDN as node names.
I am not clear why was it added as it worked fine with pacemaker before and after commenting out the code it still works fine. I didn't want to commit a removal as I'm not sure if any code that I can't test relies on it.
Basically if the defaults are not set the ha_cluster role does a good job generating the correct config based on ansible facts and provided variables.
This change introduces a regression by setting defaults which don't match ansible facts when FQDNs are used in inventory and cluster node names.
It may be possible to fix this by changing
node_name: "{{ ansible_hostname }}"
tonode_name: "{{ inventory_name }}"
, but as I mention it doesn't seem like this code is needed?The text was updated successfully, but these errors were encountered: