Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf deep dive with Million Lint #8030

Draft
wants to merge 14 commits into
base: next
Choose a base branch
from
Draft

perf deep dive with Million Lint #8030

wants to merge 14 commits into from

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Dec 13, 2024

This PR isn't meant to be merged, but split into smaller PRs. TODO comments added here will be moved to a Linear followup.

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 10:06am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 10:06am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 10:06am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 10:06am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 13, 2024 10:06am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Dec 13, 2024 10:04 AM (UTC)

❌ Failed Tests (6) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 15s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 56s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 4m 27s 0 0 6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 49s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 48s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 53s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 13 Dec 2024 10:05:05 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.6 efps (39ms) 27.4 efps (37ms) -3ms (-6.4%)
article (body) 69.9 efps (14ms) 67.8 efps (15ms) +0ms (-/-%)
article (string inside object) 26.3 efps (38ms) 28.6 efps (35ms) -3ms (-7.9%)
article (string inside array) 25.0 efps (40ms) 26.3 efps (38ms) -2ms (-5.0%)
recipe (name) 47.6 efps (21ms) 55.6 efps (18ms) -3ms (-14.3%)
recipe (description) 52.6 efps (19ms) 62.5 efps (16ms) -3ms (-15.8%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 16.7 efps (60ms) 18.5 efps (54ms) -6ms (-10.0%)
synthetic (string inside object) 19.4 efps (52ms) 18.9 efps (53ms) +2ms (+2.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 40ms 45ms 65ms 144ms 9.5s
article (body) 14ms 15ms 20ms 164ms 190ms 5.1s
article (string inside object) 38ms 47ms 71ms 163ms 178ms 7.2s
article (string inside array) 40ms 41ms 49ms 262ms 143ms 6.9s
recipe (name) 21ms 23ms 25ms 43ms 0ms 7.4s
recipe (description) 19ms 21ms 23ms 42ms 0ms 5.0s
recipe (instructions) 6ms 7ms 8ms 50ms 0ms 3.3s
synthetic (title) 60ms 64ms 72ms 282ms 879ms 17.9s
synthetic (string inside object) 52ms 54ms 59ms 130ms 453ms 8.6s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 38ms 52ms 104ms 166ms 11.6s
article (body) 15ms 18ms 26ms 169ms 286ms 5.6s
article (string inside object) 35ms 38ms 45ms 65ms 130ms 6.7s
article (string inside array) 38ms 40ms 43ms 152ms 0ms 6.6s
recipe (name) 18ms 21ms 25ms 49ms 0ms 7.2s
recipe (description) 16ms 16ms 19ms 32ms 0ms 4.2s
recipe (instructions) 6ms 7ms 8ms 15ms 0ms 3.1s
synthetic (title) 54ms 56ms 64ms 331ms 609ms 13.9s
synthetic (string inside object) 53ms 57ms 87ms 273ms 548ms 8.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant