Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): refer to correct env variable for Playwright version #8026

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

skogsmaskin
Copy link
Member

@skogsmaskin skogsmaskin commented Dec 12, 2024

The key here should be made from env, and not vars.

As proved by cache names under https://github.com/sanity-io/sanity/actions/caches

Invalid entry for e2e:

image

Valid entry for component tests:

image

@skogsmaskin skogsmaskin requested a review from a team as a code owner December 12, 2024 14:37
@skogsmaskin skogsmaskin requested review from cngonzalez and removed request for a team December 12, 2024 14:37
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:37pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:37pm
test-next-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:37pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:37pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 12, 2024 2:37pm

Copy link
Contributor

No changes to documentation

@skogsmaskin skogsmaskin requested review from bjoerge and removed request for cngonzalez December 12, 2024 14:39
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@skogsmaskin skogsmaskin added this pull request to the merge queue Dec 12, 2024
Merged via the queue into next with commit cefd55a Dec 12, 2024
50 of 51 checks passed
@skogsmaskin skogsmaskin deleted the ci/fix-invalid-version-env-ref branch December 12, 2024 14:42
Copy link
Contributor

Component Testing Report Updated Dec 12, 2024 2:46 PM (UTC)

❌ Failed Tests (6) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 56s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 4m 27s 0 0 6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 50s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 48s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 42s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 53s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Thu, 12 Dec 2024 14:49:49 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.0 efps (46ms) 22.2 efps (45ms) -1ms (-1.1%)
article (body) 69.7 efps (14ms) 63.3 efps (16ms) +1ms (-/-%)
article (string inside object) 24.4 efps (41ms) 24.4 efps (41ms) +0ms (-/-%)
article (string inside array) 21.7 efps (46ms) 21.7 efps (46ms) +0ms (-/-%)
recipe (name) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%)
recipe (description) 62.5 efps (16ms) 58.8 efps (17ms) +1ms (+6.3%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 17.9 efps (56ms) 18.2 efps (55ms) -1ms (-1.8%)
synthetic (string inside object) 19.6 efps (51ms) 19.2 efps (52ms) +1ms (+2.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 46ms 50ms 59ms 262ms 352ms 11.3s
article (body) 14ms 17ms 28ms 151ms 185ms 5.2s
article (string inside object) 41ms 43ms 46ms 192ms 156ms 7.3s
article (string inside array) 46ms 49ms 53ms 180ms 170ms 7.3s
recipe (name) 19ms 21ms 24ms 44ms 0ms 7.2s
recipe (description) 16ms 18ms 19ms 27ms 0ms 4.4s
recipe (instructions) 5ms 7ms 8ms 24ms 0ms 3.1s
synthetic (title) 56ms 58ms 66ms 271ms 642ms 14.2s
synthetic (string inside object) 51ms 54ms 61ms 351ms 543ms 8.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 45ms 52ms 82ms 325ms 386ms 11.6s
article (body) 16ms 18ms 27ms 173ms 216ms 5.4s
article (string inside object) 41ms 44ms 48ms 170ms 162ms 7.7s
article (string inside array) 46ms 52ms 57ms 182ms 155ms 7.4s
recipe (name) 19ms 21ms 24ms 40ms 0ms 7.1s
recipe (description) 17ms 19ms 22ms 33ms 0ms 4.5s
recipe (instructions) 5ms 7ms 8ms 19ms 0ms 3.1s
synthetic (title) 55ms 56ms 59ms 335ms 662ms 14.6s
synthetic (string inside object) 52ms 54ms 57ms 317ms 229ms 8.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants