Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): release events types are lowercase #8024

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Content lake has renamed the events types that are returned from the events api to camel case.
This reflects that update in the studio.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner December 12, 2024 11:56
@pedrobonamin pedrobonamin requested review from juice49 and removed request for a team December 12, 2024 11:56
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:43pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:43pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:43pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:43pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 2:43pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Component Testing Report Updated Dec 12, 2024 2:37 PM (UTC)

❌ Failed Tests (6) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 57s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 4m 27s 0 0 6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 13s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 3m 3s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 52s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 15s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 44s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 57s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 12, 2024

⚡️ Editor Performance Report

Updated Thu, 12 Dec 2024 14:39:50 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.7 efps (41ms) 16.7 efps (60ms) +20ms (+48.1%) 🔴
article (body) 67.3 efps (15ms) 68.0 efps (15ms) -0ms (-/-%)
article (string inside object) 24.4 efps (41ms) 17.7 efps (57ms) +16ms (+37.8%) 🔴
article (string inside array) 23.3 efps (43ms) 16.7 efps (60ms) +17ms (+39.5%) 🔴
recipe (name) 45.5 efps (22ms) 26.7 efps (38ms) +16ms (+70.5%) 🔴
recipe (description) 50.0 efps (20ms) 29.4 efps (34ms) +14ms (+70.0%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 18.9 efps (53ms) 7.2 efps (139ms) +86ms (+162.3%) 🔴
synthetic (string inside object) 18.9 efps (53ms) 7.2 efps (139ms) +86ms (+161.3%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 45ms 77ms 210ms 294ms 10.8s
article (body) 15ms 18ms 22ms 145ms 54ms 5.3s
article (string inside object) 41ms 44ms 51ms 230ms 395ms 7.6s
article (string inside array) 43ms 47ms 51ms 181ms 136ms 7.1s
recipe (name) 22ms 24ms 26ms 47ms 0ms 7.5s
recipe (description) 20ms 22ms 25ms 38ms 0ms 4.8s
recipe (instructions) 6ms 8ms 10ms 23ms 0ms 3.3s
synthetic (title) 53ms 55ms 64ms 292ms 493ms 14.1s
synthetic (string inside object) 53ms 55ms 72ms 396ms 836ms 8.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 60ms 62ms 76ms 267ms 1218ms 13.2s
article (body) 15ms 17ms 37ms 209ms 329ms 5.9s
article (string inside object) 57ms 60ms 76ms 273ms 1119ms 8.9s
article (string inside array) 60ms 64ms 74ms 412ms 1395ms 9.3s
recipe (name) 38ms 42ms 49ms 93ms 96ms 9.3s
recipe (description) 34ms 35ms 39ms 81ms 34ms 6.1s
recipe (instructions) 6ms 8ms 9ms 20ms 10ms 3.4s
synthetic (title) 139ms 149ms 174ms 615ms 7355ms 23.8s
synthetic (string inside object) 139ms 145ms 157ms 449ms 5618ms 14.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin
Copy link
Contributor Author

I'm merging this one, I think it doesn't need a peer review it's just a rename of types that came from content lake, and it's going to a feature branch.

@pedrobonamin pedrobonamin merged commit ea86580 into corel Dec 12, 2024
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant