Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade react-json-inspector #8017

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Dec 11, 2024

Description

Upgrades @rexxars/react-json-inspector to the latest version, which is compatible with React 19 and drops lifecycle events that are deprecated. The conversion was a bit quick and dirty, but from what I can tell things seems to work fine.

What to review

"Inspect document" and vision results works as expected

Testing

Check out the preview deployment, see that it matches current look/behavior

Notes for release

None

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 9:52pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 9:52pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 9:52pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 9:52pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 11, 2024 9:52pm

@rexxars rexxars marked this pull request as ready for review December 11, 2024 21:38
@rexxars rexxars requested a review from a team as a code owner December 11, 2024 21:38
@rexxars rexxars requested review from juice49 and removed request for a team December 11, 2024 21:38
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rexxars/[email protected] None +3 281 kB rexxars

View full report↗︎

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Dec 11, 2024 9:48 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 15s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 1m 0s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 9s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 16s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 59s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 56s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 15s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 44s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 59s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Wed, 11 Dec 2024 21:50:34 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.6 efps (39ms) 26.0 efps (39ms) -1ms (-1.3%)
article (body) 63.7 efps (16ms) 73.0 efps (14ms) -2ms (-/-%)
article (string inside object) 25.0 efps (40ms) 26.0 efps (39ms) -2ms (-3.8%)
article (string inside array) 24.4 efps (41ms) 22.7 efps (44ms) +3ms (+7.3%)
recipe (name) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%)
recipe (description) 58.8 efps (17ms) 58.8 efps (17ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 17.9 efps (56ms) 17.2 efps (58ms) +2ms (+3.6%)
synthetic (string inside object) 18.2 efps (55ms) 18.2 efps (55ms) +0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 42ms 48ms 83ms 155ms 10.8s
article (body) 16ms 17ms 22ms 119ms 209ms 5.2s
article (string inside object) 40ms 43ms 51ms 195ms 161ms 6.8s
article (string inside array) 41ms 43ms 48ms 159ms 166ms 7.0s
recipe (name) 19ms 22ms 26ms 41ms 0ms 7.0s
recipe (description) 17ms 18ms 21ms 40ms 0ms 4.5s
recipe (instructions) 5ms 6ms 8ms 10ms 0ms 3.0s
synthetic (title) 56ms 60ms 68ms 346ms 759ms 14.0s
synthetic (string inside object) 55ms 58ms 64ms 464ms 579ms 8.7s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 42ms 45ms 153ms 164ms 10.0s
article (body) 14ms 16ms 22ms 101ms 201ms 5.2s
article (string inside object) 39ms 40ms 46ms 75ms 142ms 6.7s
article (string inside array) 44ms 46ms 55ms 232ms 258ms 7.4s
recipe (name) 19ms 21ms 25ms 70ms 0ms 7.4s
recipe (description) 17ms 19ms 20ms 66ms 9ms 4.5s
recipe (instructions) 5ms 6ms 8ms 21ms 0ms 3.1s
synthetic (title) 58ms 62ms 73ms 326ms 773ms 13.4s
synthetic (string inside object) 55ms 59ms 64ms 741ms 1283ms 9.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@stipsan
Copy link
Member

stipsan commented Dec 11, 2024

This is awesome 💖

Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🙏

@rexxars rexxars added this pull request to the merge queue Dec 14, 2024
Merged via the queue into next with commit cf7afaf Dec 14, 2024
57 checks passed
@rexxars rexxars deleted the fix/upgrade-json-inspector branch December 14, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants