Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump minimum requirement of @sanity/import and @sanity/export #8012

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Dec 11, 2024

Description

Bumps the minimum required patch versions of @sanity/import and @sanity/export to get rid of a couple of sources of scary-looking deprecation warnings during npm install

Testing

Existing tests should be enough

Notes for release

n/a

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:07am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:07am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:07am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 11, 2024 10:07am

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@sanity/[email protected], npm/@sanity/[email protected]

View full report↗︎

Copy link
Contributor

No changes to documentation

@bjoerge bjoerge marked this pull request as ready for review December 11, 2024 10:02
@bjoerge bjoerge requested a review from a team as a code owner December 11, 2024 10:02
@bjoerge bjoerge requested review from RitaDias and pedrobonamin and removed request for a team and RitaDias December 11, 2024 10:02
Copy link
Contributor

Component Testing Report Updated Dec 11, 2024 10:04 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 18s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 1m 0s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 17s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 9s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 15s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 49s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 56s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 15s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 45s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 0s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Wed, 11 Dec 2024 10:07:04 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.6 efps (39ms) 22.2 efps (45ms) +6ms (+15.4%)
article (body) 78.1 efps (13ms) 67.6 efps (15ms) +2ms (-/-%)
article (string inside object) 25.0 efps (40ms) 23.8 efps (42ms) +2ms (+5.0%)
article (string inside array) 23.5 efps (43ms) 21.7 efps (46ms) +4ms (+8.2%)
recipe (name) 50.0 efps (20ms) 52.6 efps (19ms) -1ms (-5.0%)
recipe (description) 55.6 efps (18ms) 58.8 efps (17ms) -1ms (-5.6%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%)
synthetic (title) 19.6 efps (51ms) 19.6 efps (51ms) +0ms (-/-%)
synthetic (string inside object) 19.6 efps (51ms) 20.8 efps (48ms) -3ms (-5.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 43ms 63ms 167ms 179ms 10.7s
article (body) 13ms 16ms 21ms 146ms 221ms 5.4s
article (string inside object) 40ms 43ms 51ms 227ms 246ms 7.1s
article (string inside array) 43ms 45ms 50ms 76ms 133ms 7.1s
recipe (name) 20ms 22ms 24ms 45ms 0ms 7.4s
recipe (description) 18ms 20ms 21ms 44ms 0ms 4.5s
recipe (instructions) 6ms 7ms 10ms 21ms 0ms 3.1s
synthetic (title) 51ms 57ms 64ms 87ms 385ms 14.7s
synthetic (string inside object) 51ms 53ms 61ms 477ms 759ms 8.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 45ms 48ms 55ms 197ms 166ms 10.9s
article (body) 15ms 16ms 20ms 147ms 222ms 5.3s
article (string inside object) 42ms 45ms 52ms 86ms 246ms 7.1s
article (string inside array) 46ms 49ms 54ms 172ms 143ms 7.3s
recipe (name) 19ms 22ms 31ms 49ms 0ms 6.8s
recipe (description) 17ms 18ms 20ms 39ms 0ms 4.4s
recipe (instructions) 5ms 6ms 7ms 47ms 19ms 3.1s
synthetic (title) 51ms 53ms 55ms 131ms 555ms 13.8s
synthetic (string inside object) 48ms 50ms 58ms 290ms 105ms 7.8s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@bjoerge bjoerge added this pull request to the merge queue Dec 11, 2024
Merged via the queue into next with commit c7ec5f9 Dec 11, 2024
57 checks passed
@bjoerge bjoerge deleted the bump/import-export branch December 11, 2024 10:10
bjoerge added a commit that referenced this pull request Dec 12, 2024
* next: (49 commits)
  fix: delays rendering the Start in Create banner until document is ready (#8020)
  fix(deps): update dependency @sanity/ui to ^2.10.9 (#8009)
  chore(deps): dedupe pnpm-lock.yaml (#8023)
  test(playwright-ct): fix issues and flake (#8016)
  feat(cli): misc copy changes (#8003)
  feat(cli): remove is-builtin-module (#6579)
  v3.67.1
  chore(deps): bump minimum requirement of @sanity/import and @sanity/export (#8012)
  chore(deps): update dependency @sanity/pkg-utils to v6.12.0 (#8010)
  fix(core): tasks UpdatedTimeAgo should be a hook (#8011)
  v3.67.0
  chore(prettier): fix unformatted files 🤖 ✨ (#8006)
  chore: reduce renovate double PR noise
  fix(deps): update dependency @sanity/ui to ^2.10.7 (#8005)
  fix(deps): update dependency @sanity/ui to ^2.10.7 (#7998)
  feat(cli): use `@vercel/frameworks` in `bootstrapRemoteTemplate` (#8001)
  feat: switch create integration to opt-out flow (#8002)
  feat: use eslint 9 for new studios (#7978)
  fix(sanity): optimise getLeafWeights to not stack overflow (#7999)
  feat(test-studio): enable `groq2024` search strategy
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants