feat(core): releases history #7973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
⚡️ Editor Performance ReportUpdated Fri, 13 Dec 2024 10:06:40 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
|
Component Testing Report Updated Dec 13, 2024 10:06 AM (UTC) ❌ Failed Tests (6) -- expand for details
|
pedrobonamin
commented
Dec 9, 2024
pedrobonamin
commented
Dec 9, 2024
packages/sanity/src/core/releases/tool/detail/ReleaseDashboardActivityPanel.tsx
Outdated
Show resolved
Hide resolved
pedrobonamin
force-pushed
the
corel-release-history
branch
from
3f749c7 to
0e8b2a9
Compare
pedrobonamin
force-pushed
the
corel-release-history
branch
from
832db69 to
d69186f
Compare
bjoerge
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Super solid work, @pedrobonamin! Appreciate the thorough unit tests inclued as well. Left a few comments, please have a look. No blockers for merge I think :)
packages/sanity/src/core/releases/tool/detail/ReleaseActivityListItem.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/releases/tool/detail/ReleaseStatusItems.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/releases/tool/detail/events/getReleaseActivityEvents.ts
Show resolved
Hide resolved
| vi.resetAllMocks() | ||
| }) | ||
| it('should not get the events if release is undefined', () => { | ||
| testScheduler.run(({expectObservable, hot}) => { |
There was a problem hiding this comment.
Oh, cool – first time I've seen this pattern with hot/cold
There was a problem hiding this comment.
First time using it, it's a very nice way to "mock" the observables and indicate they are "alive" and that we could receive updates from it.
|
|
||
| return fetchLogs({fromTransaction: cachedTransactions[0]?.id, toTransaction: toTransaction}) | ||
| .pipe( | ||
| expand((response) => { |
There was a problem hiding this comment.
Oh, neat! Don't think I've ever had a use for expand before. Makes the whole "keep fetching until reaching the end" logic look so simple!
There was a problem hiding this comment.
I've been going deep into rxjs with this latest changes and I'm really surprised how it makes async functions really easy and declarative. Wish I knew all of this earlier.
packages/sanity/src/core/releases/tool/detail/events/getReleaseEditEvents.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implements corel-236
Introduces release events, using the
translogand therelease-eventsapi.Why we get events from the translog and the api?
The events API doesn't generate events for the edits that happen in the release metadata, we need to get those from the
translog. Also, the creation event from the API doesn't contain the metadata information, so we get that from the translog.What to review
Testing
Tests have been added for the new observables and logic.
Notes for release