Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sanity): migrate more packages to vitest #7573

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Oct 2, 2024

Description

Migrates @sanity/block-tools and sanity to vitest

What to review

Changes makes sense

Testing

Tests pass

Notes for release

N/A

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 5:34pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 5:34pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 5:34pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 5:34pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 5:34pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 5:34pm

Copy link
Contributor

github-actions bot commented Oct 2, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Component Testing Report Updated Oct 3, 2024 5:45 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 35s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 15s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 2, 2024

⚡️ Editor Performance Report

Updated Thu, 03 Oct 2024 17:50:26 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 18.9 efps (53ms) 18.5 efps (54ms) +1ms (+1.9%)
article (body) 59.3 efps (17ms) 63.7 efps (16ms) -1ms (-6.8%)
article (string inside object) 19.2 efps (52ms) 19.2 efps (52ms) +0ms (-/-%)
article (string inside array) 15.3 efps (66ms) 15.2 efps (66ms) +1ms (+0.8%)
recipe (name) 29.4 efps (34ms) 30.3 efps (33ms) -1ms (-2.9%)
recipe (description) 32.3 efps (31ms) 33.3 efps (30ms) -1ms (-3.2%)
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (7ms) +1ms (-/-%)
synthetic (title) 15.4 efps (65ms) 15.2 efps (66ms) +1ms (+1.5%)
synthetic (string inside object) 15.7 efps (64ms) 15.9 efps (63ms) -1ms (-0.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 53ms 59ms 98ms 148ms 1012ms 13.5s
article (body) 17ms 19ms 22ms 140ms 178ms 5.4s
article (string inside object) 52ms 54ms 63ms 145ms 747ms 8.7s
article (string inside array) 66ms 69ms 82ms 142ms 1601ms 9.7s
recipe (name) 34ms 36ms 42ms 72ms 48ms 9.4s
recipe (description) 31ms 32ms 35ms 62ms 31ms 6.3s
recipe (instructions) 7ms 9ms 9ms 11ms 0ms 3.3s
synthetic (title) 65ms 70ms 83ms 285ms 1945ms 16.4s
synthetic (string inside object) 64ms 65ms 71ms 234ms 1648ms 9.9s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 54ms 59ms 67ms 215ms 1024ms 13.4s
article (body) 16ms 17ms 22ms 137ms 135ms 5.1s
article (string inside object) 52ms 56ms 61ms 158ms 693ms 8.7s
article (string inside array) 66ms 72ms 78ms 212ms 1685ms 9.7s
recipe (name) 33ms 36ms 41ms 58ms 57ms 9.2s
recipe (description) 30ms 35ms 39ms 56ms 44ms 6.4s
recipe (instructions) 7ms 10ms 11ms 36ms 0ms 3.4s
synthetic (title) 66ms 70ms 80ms 270ms 1939ms 16.7s
synthetic (string inside object) 63ms 68ms 80ms 278ms 1658ms 9.5s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

- chore(test): add sharding to test workflow
@binoy14 binoy14 force-pushed the test-migrate-sanity branch from 0dcfa77 to a511081 Compare October 3, 2024 17:32
Copy link
Contributor Author

binoy14 commented Oct 3, 2024

@binoy14 binoy14 changed the base branch from next to test-migrate-block-tools October 3, 2024 17:34
Base automatically changed from test-migrate-block-tools to test-migrate-repo October 3, 2024 17:39
@binoy14 binoy14 merged commit a511081 into test-migrate-repo Oct 3, 2024
51 checks passed
@binoy14 binoy14 deleted the test-migrate-sanity branch October 3, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants