chore(releases): moving from bundles to releases directory #7500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Sep 15, 2024 10:05 PM (UTC) ✅ All Tests Passed -- expand for details
|
jordanl17
requested review from
bjoerge,
juice49,
RitaDias and
pedrobonamin
RitaDias
approved these changes
Sep 18, 2024
pedrobonamin
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Thanks for this @jordanl17 !
Looks good to me, would like if we could spend some time debugging the mock issues in a follow up, specially before merging to next .
This will probably be fixed once we switch to vitest.
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
* chore(releases): moving releases/components to releases/tool/components * chore(releases): moving bundles/components to releases/components * chore(releases): moving bundles/hooks to releases/hooks * chore(releases): moving rest of bundles to releases * chore(releases): fixing various test imports * chore(releases): fixing various test imports * chore(releases): fixing various test imports * chore(releases): further experimentation on SanityDocumentPreview test failures * chore(releases): fixing ReleaseSummary and Review by mocking components * chore(releases): reverting irrelevent changes
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
* chore(releases): moving releases/components to releases/tool/components * chore(releases): moving bundles/components to releases/components * chore(releases): moving bundles/hooks to releases/hooks * chore(releases): moving rest of bundles to releases * chore(releases): fixing various test imports * chore(releases): fixing various test imports * chore(releases): fixing various test imports * chore(releases): further experimentation on SanityDocumentPreview test failures * chore(releases): fixing ReleaseSummary and Review by mocking components * chore(releases): reverting irrelevent changes
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
* chore(releases): moving releases/components to releases/tool/components * chore(releases): moving bundles/components to releases/components * chore(releases): moving bundles/hooks to releases/hooks * chore(releases): moving rest of bundles to releases * chore(releases): fixing various test imports * chore(releases): fixing various test imports * chore(releases): fixing various test imports * chore(releases): further experimentation on SanityDocumentPreview test failures * chore(releases): fixing ReleaseSummary and Review by mocking components * chore(releases): reverting irrelevent changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrating the
core/bundlesdirectories tocore/bundles.Note that the methods in these files haven't been changed, only the location of the files.
The directory that previously existed in
core/releases/componentsincluded all the components for the releases plugin (since previouslycore/releasesincluded only the code for the plugin). This directory has therefore been moved tocore/releases/tool/components, which feels sensible given that the exports from these components are only used in thetooldirectory.What to review
Testing
Tests mostly involved just updating the path for mocks.
However there were particular issues with
ReleasesSummaryandReleasesReview- for inexplicable reasons, theSanityDefaultPreviewcomponent wasn't receiving it's correct imports, and despite considerable investigation, it seems that there is perhaps a cyclic dependency/mock somewhere which I couldn't track down. Therefore, instead a mock has been added to these 2 tests to cover the issues instead - the tests here are still valid, given that extraneous logic is being mocked and not the parts that are relevant to the testing scope.Notes for release
N/A