Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): remove the CRA starter dev studio #5076

Merged

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Oct 26, 2023

Description

I don't think this provides us with any practical value, and it's causing dependency issues with jest since it depends on react-scripts which doesn't seem actively maintained anymore (it's last publish was April last year).

What to review

  • Any problems with doing this?

Notes for release

n/a - chore

@bjoerge bjoerge requested review from rexxars and binoy14 October 26, 2023 12:57
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 26, 2023 1:15pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 1:15pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 26, 2023 1:15pm

@github-actions
Copy link
Contributor

No changes to documentation

@socket-security
Copy link

socket-security bot commented Oct 26, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/connect-history-api-fallback 1.5.2 None +0 4.87 kB types

🚮 Removed packages: [email protected]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Component Testing Report Updated Oct 26, 2023 1:17 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 27s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 13s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 43s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 5s 3 0 0

Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@bjoerge bjoerge merged commit 1720f9c into chore/jest-28-migration-rebase Oct 26, 2023
26 checks passed
@bjoerge bjoerge deleted the chore/remove-starter-cra-studio branch October 26, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants