Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): revert convert symlinkDependencies script to ts #5008

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Oct 18, 2023

Description

Small change that reverts an earlier conversion of the symlinkDependencies script from js to ts. I didn't realize it was referred to by CLI tests, which currently fails when trying execute it. The exec failure is currently being swallowed silently, so the tests end up being run against the latest version from npm instead of the symlinked one – new PR coming up to fix that.

What to review

Hardly any change except from rename + removing a couple of type annotations. Also added a comment clarifying that it should stay as plain js.

Notes for release

n/a – internal

@bjoerge bjoerge requested a review from rexxars October 18, 2023 20:43
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 18, 2023 8:44pm
test-studio ✅ Ready (Inspect) Visit Preview Oct 18, 2023 8:44pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 18, 2023 8:44pm

@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

Component Testing Report Updated Oct 18, 2023 8:47 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 5s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 12s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 43s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 5s 3 0 0

@bjoerge bjoerge added this pull request to the merge queue Oct 19, 2023
Merged via the queue into next with commit d19aa5e Oct 19, 2023
14 checks passed
@bjoerge bjoerge deleted the fix/revert-convert-symlink-deps-to-ts branch October 19, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants