Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-875 As PSD we would like to upgrade Samples Extraction to Ruby 3 and Rails 7 so that we keep up to date with our dependencies. #277

Open
2 tasks
TWJW-SANGER opened this issue Aug 15, 2023 · 3 comments
Labels

Comments

@TWJW-SANGER
Copy link

Describe the Housekeeping
As PSD we would like to upgrade Samples Extraction to Ruby 3 and Rails 7 so that we keep up to date with our dependencies.

Blocking issues

Additional context

  • Review and update any other dependencies that require updating as part of this process.
  • Ensure any existing unit and integration tests pass
@KatyTaylor KatyTaylor added the Size: L Large - large effort & risk label Sep 28, 2023
@KatyTaylor
Copy link

I've put this as large, since Eduardo's having a fair amount of trouble currently upgrading SS to Ruby 3. Hopefully we'll get some learnings from that though!

@BenTopping
Copy link

BenTopping commented Sep 13, 2024

Adjusting this to small since samples extraction is already on ruby 3 at the time this has been picked up and the rails 7 upgrade was straight forward.

@BenTopping
Copy link

BenTopping commented Oct 30, 2024

Maybe not so straightforward 😅

The rails 7 upgrade caused some unreproducible errors in production and I have created the following story to address the problems #378. The main problem is that samples extraction's test suite is not comprehensive enough to rely on. The relase was yanked so develop and master are back in a 'stable' state but the rails 7 upgrade needs to be re-attempted at some point.

@BenTopping BenTopping reopened this Oct 30, 2024
@BenTopping BenTopping removed their assignment Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants