Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-190 SS v2 Clean Up Tasks #2172

Open
7 tasks
harrietc52 opened this issue Jan 17, 2025 · 0 comments
Open
7 tasks

Y24-190 SS v2 Clean Up Tasks #2172

harrietc52 opened this issue Jan 17, 2025 · 0 comments
Assignees

Comments

@harrietc52
Copy link
Contributor

harrietc52 commented Jan 17, 2025

Describe the Housekeeping
As a developer, we would like to clean up the remaining tasks, following the update from Sequencescape API v1 -> v2. This reflects the tasks for Sequencescape

Tasks:

  • Update JavaScript file with v2 endpoints in: bundle exec rake devour:create_config > resources.js.
  • Review TODOs against Y24-190.
  • Remove traces of v1 from Limber code, tests and factories.
    • Remove json method calls in tests.
  • Rename factories with v2 in the name to not be numbered.
  • Add an alias on Limber to shorten the usage of Sequencescape::API:v2:: module calls.
  • move api/v2/plate DEFAULT_INCLUDES to ongoing_plates.rb (dual also with v2.rb)

Blocking issues
Describe any other issues or tickets that may be blocking this change.

Additional context
Add any other context about the problem here.

Sibling story: sanger/sequencescape#4617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants