Y24-502 - [BUG] Incorrect Warning Displayed in Limber for Active Submission Requests in scRNA LRC GEM-X 5p GEMs Input Plates

[seenanair]

Describe the bug

As part of the scRNA LRC GEM-X 5p GEMs input plate submission, the submission was successfully completed in SS, and the well has an active submission request. However, when viewing the plate in Limber, a warning is displayed:

"Submission (active) is not present for this labware. Any further work conducted from this plate may run into issues at the end of the pipeline."

Despite this warning, it does not prevent users from proceeding through the rest of the pipeline. In fact, users have been able to complete the entire pipeline process successfully.

RT Ticket Number
If applicable

To Reproduce
Steps to reproduce the behaviour:

1. Create a sample manifest using template 'scRNA Core Pools Plate'
2. Upload manifest with samples added to wells
3. Build a Submission using order template 'Limber-Htp- scRNA Core cDNA Prep GEM-X 5p GEMs Input'
4. Check the plate in Limber
5. The following warning message will be displayed

Expected behaviour

• Limber should display warnings only when a submission request is genuinely missing or inactive for the specified labware.
  If a submission request is active and valid, no warning should appear.

• To improve user experience, it would be helpful to display the request state by submission. This would better guide users in making informed decisions about whether to proceed with the pipeline.

[andrewsparkes]

The green suggested action button is showing, suggesting the code that makes the determination for the next step is finding the right request type for this pipeline. Whereas the warning message showing suggests that code is filtering out the request for some reason.
Tom wondered why the code for those two things isn't shared at some level as they both interrogate what request is active.
This is an input/stock plate so treated differently in the code to an intermediate plate, so possibly the warning is something to do with that difference?

NB. Also fix the inconsistent config, in SS the GEMs Input plate is defined as cherrypickable target false whereas it is set to true in Limber.

[TWJW-SANGER]

Just a note this issue #1167, seems like a similar problem where an incorrect warning is displayed.

[andrewsparkes]

We had a look together:
The problem is the validation generating the message assumes a Library Request, whereas in this case (and many others) it will be a Customer Request. The current validation is checking for tags and passable library requests, which is not appropriate for Customer Requests. There are also 2 different versions of the validation in different parts of the code, doing slightly different things.

Discussed enhancing the validation to check for an active request then using sti_type to give the request type and doing a different check and message depending on type.

Will probably need more discussion about how to know what type of request we should be expecting for the labware purpose we are on, and what is appropriate for validation checks and warning messages for the different types of requests.