Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-487: Add tooltips to racked tube icons #2113

Open
wants to merge 4 commits into
base: y24-088-tuberacks-epic
Choose a base branch
from

Conversation

StephenHulme
Copy link
Contributor

@StephenHulme StephenHulme commented Dec 9, 2024

Closes #2098

Changes proposed in this pull request

  • Add tooltips to racked tube icons
  • Minor refactoring, rename well to tube

It currently shows:

location: purpose-name tube-name human-barcode

If more fields are required, another (or different) request will need to be made to SS to retreive the additional fields

Screenshot

Screenshot 2024-12-12 at 09 52 21

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme changed the base branch from develop to y24-088-tuberacks-epic December 9, 2024 16:38
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.68%. Comparing base (db9b440) to head (b7ca2c7).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           y24-088-tuberacks-epic    #2113      +/-   ##
==========================================================
- Coverage                   80.78%   80.68%   -0.11%     
==========================================================
  Files                         482      483       +1     
  Lines                       18295    18299       +4     
  Branches                      269      268       -1     
==========================================================
- Hits                        14780    14764      -16     
- Misses                       3513     3533      +20     
  Partials                        2        2              
Flag Coverage Δ
javascript 74.05% <ø> (-0.18%) ⬇️
pull_request 80.68% <100.00%> (-0.11%) ⬇️
push 80.68% <100.00%> (+<0.01%) ⬆️
ruby 91.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a full page screenshot as well? I am trying to figure out how Fail screen and tooltips would look like. I can't figure out if there is any interference between these tooltips and QC tooltips. Thanks.

@StephenHulme
Copy link
Contributor Author

Hi @yoldas,

Here is a full screenshot as requested:

Screenshot 2025-01-17 at 11 20 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-487 - Tooltips on tube icons
3 participants