Y24-287 - [BUG] Exception 27/08/2024 at 13:50

[BenTopping]

Email subject line
[Psd-exceptions] [Limber PRODUCTION] print_jobs#create (NoMethodError) "undefined method `id' for nil:NilClass"

Error body

A NoMethodError occurred in print_jobs#create:

  undefined method `id' for nil:NilClass
  app/models/print_job.rb:138:in `pmb_label_template_id'

Acceptance Criteria

• Look into this exception and fix the code to handle the exception sensibly.
• Document the root cause and solution in a comment on this issue.

Additional information
The id of the user who triggered this error is often shown in the exception email, in case you need to communicate with them.

[BenTopping]

Fix linked in PR above.

Cause

When a label template which doesn't exist in print my barcode is attempted to be accessed in app/models/print_job.rb it throws an error. In this case it is the template 'sqsc_384plate_label_template_code39'. This template is documented as unusable but included 'for completeness', see comment here.

This was accessed because a user, presumably incorrectly, tried to print a 'plate_384_single' template to a toshiba printer. The toshiba printer is still selectable, despite not having a valid template, because limber displays all 384 printers and doesn't have a filter for print service type.

Fix

Handle label template check safely in app/models/print_job.rb for the case where the label template does not exist. It now provides a clear error message: Pmb Unable to find label template: <template_name>.