Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

07-31-2015 Remove deprecated methods associated with PR 155 #163

Closed
elrayle opened this issue Jul 21, 2015 · 3 comments
Closed

07-31-2015 Remove deprecated methods associated with PR 155 #163

elrayle opened this issue Jul 21, 2015 · 3 comments
Assignees

Comments

@elrayle
Copy link
Contributor

elrayle commented Jul 21, 2015

Search for DEPRECATION and remove any deprecated methods with a target date of 07-31-2015 or earlier.

@grosscol
Copy link
Member

grosscol commented Aug 4, 2015

aggregates_collections.rb still has a non-deprecated child_collections_ids method. It's a convenience method and the only method left in the AggregatesCollections module. Not sure where this method should live or what the a better name for the module might be.

    def child_collection_ids
      child_collections.map(&:id)
    end

Perhaps collection_behavior.rb is a better place for it. Thoughts?

@grosscol
Copy link
Member

grosscol commented Aug 4, 2015

The get/add/remove related object calls are not deprecated, but this issue is being punted on until the resolution of #86.

@tpendragon
Copy link
Contributor

@grosscol If you remove that method you should still get child_collection_ids from the association readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants