-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reevaluate dependency upon ActiveFedora #172
Comments
What's the contract for a supported ORM? Instead of hard coding, could we make I suspect 4b10480 will break Hyrax, since both |
I'm definitely in support of making I needed to squash a number of commits to get stubbing properly working for 8a965f1 and 0f9b2ad. Regarding the contract, my suspicion is that it is probably going to require either |
@no-reply Does Hyrax use the features that hydra-editor uses the ORM for? I vaguely remember just using the partial lookup bit, but I might be mixed up. |
For instance, Hyrax seems to have its own ControllerResource: https://github.com/samvera/hyrax/blob/5a9d1be16ee1a9150646384471992b03aab527a5/lib/hyrax/controller_resource.rb |
Maybe samvera/hydra-works#352 provides some guidance here? |
This was proposed by @tpendragon, and perhaps calls to the Gem (such as what is found on https://github.com/samvera/hydra-editor/blob/master/lib/hydra_editor/controller_resource.rb#L3) could be removed for a future minor release.
The text was updated successfully, but these errors were encountered: