Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve syntax highlighting #4

Open
1 of 7 tasks
samrap opened this issue Jul 5, 2018 · 2 comments
Open
1 of 7 tasks

Improve syntax highlighting #4

samrap opened this issue Jul 5, 2018 · 2 comments
Assignees
@samrap
Labels
enhancement New feature or request

Comments

@samrap
Copy link
Owner

samrap commented Jul 5, 2018 •
edited
Loading

In response to #2 and #3 , the syntax highlighting can definitely use some improvement, specifically in JavaScript and Markdown.

The goal of this issue is to clean up/improve the syntax highlighting while maintaining the synthwave aesthetic and avoiding making the theme too colorful.

By version 0.3.0, the goal is to have full support for the following languages:

  • Ruby
  • Python
  • PHP
  • JavaScript
  • HTML
  • CSS/Sass
  • Markdown
@samrap samrap self-assigned this Jul 5, 2018
@samrap samrap added the enhancement New feature or request label Jul 5, 2018
@hhochart
Copy link

hhochart commented Dec 2, 2018

Hey ! Little up for the JS syntax ! Is there any way to help you with this ? :)

@samrap
Copy link
Owner Author

samrap commented Dec 3, 2018

I'd be happy to review any PRs if you wanna have a stab at it! I've been really busy at work so haven't had much time to work on this theme lately

hhochart pushed a commit to hhochart/outrun-theme-vscode that referenced this issue Dec 30, 2018
✨ (JS syntax enhancment) Some JS syntax enhancment
68229c6 
Function declaration & call is no longer white and is now orange. Class instanciation is now blue
according to PHP screenshot

Closes samrap#4
@hhochart hhochart mentioned this issue Dec 30, 2018
Closed
@kevinthenet kevinthenet mentioned this issue Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samrap samrap

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samrap @hhochart