-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(travis): reduce matrix down to 5/6 instances (ref: #118) #121
ci(travis): reduce matrix down to 5/6 instances (ref: #118) #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea to have different init systems as well, good point.
Thanks for the reviews @aboe76 and @n-rodriguez. What do you think @javierbertoli and @daks? Can we get a merge on this so that we can start rolling out this change to the ( |
@javierbertoli BTW, you've pinged someone else there, not @aboe76! Anyway, like I said at the top, I was going to do it using |
Ooops, fixed the typo 😋
Perhaps I was not clear, I meant replacing The final matrix we suggested was more on the line:
If the argument to add Perhaps I'm just nitpicking, so I'll 👍 whatever you decide. |
@javierbertoli This sounds like the ideal solution, 6 in a
|
…s#118) * The selected 6 in a "tree"-shaped matrix: - 2019.2 (py3): debian-9 centos7 opensuse-leap-15 - 2018.3 (py2): fedora-29 ubuntu-1604 - 2017.7 (py2): centos6 * Covers each `os`, each Salt version and both Python versions
b2bfd01
to
a8834e2
Compare
Thanks @myii for your hard work, and all the rest for your feedback! |
You're welcome, thank you all for your comments, reviews and feedback. Time to start reducing our Travis burdens in the other formulas! |
🎉 This PR is included in version 2.1.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
os
, each Salt version and both Python versionsI was going to go for
centos-7
andfedora-28
instead butcentos-6
is a "special" platform, which always throws up interesting situations (including not beingsystemd
-based).