-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetchFullProvidersListWithSuccess returns void #90
Comments
Hi @LetsSee! It seems I can't think of a good use case when you would need the Thanks |
Of course:
.... |
I see your point, but there are some constraints that will impede this from happening (currently). The good thing is that you don't actually need the underlying session task objects to solve the two issues you described. The only drawback is that you won't be able to cancel the network operation, and I agree that it's a pity. We will surely consider your feedback when we'll implement a major update, and I'm leaving this issue open until that moment. |
Thanks, @nemesis! Please take into account those two issues are just examples, i can imagine much more cases. |
Hi!
It would be great if API calls will return NSURLSessionDataTask or array of tasks to give users possibility to control network calls.
E.g:
- (void)fetchFullProvidersListWithSuccess:(void (^)(NSSet* providers))success failure:(SEAPIRequestFailureBlock)failure
will be
- (NSArray*)fetchFullProvidersListWithSuccess:(void (^)(NSSet* providers))success failure:(SEAPIRequestFailureBlock)failure
The text was updated successfully, but these errors were encountered: