Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from copier using template 0.5.2 #5

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented Oct 16, 2024

What does this PR do?

Update from copier update --trust using template 0.5.2

What issues does this PR fix or reference?

Fixes: Updates to latest copier template 0.5.1

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 self-assigned this Oct 16, 2024
@lkubb
Copy link
Member

lkubb commented Oct 16, 2024

You could consider running copier update --trust again and changing the answer for relax_pylint to yes, which should take care of most of the new Pylint messages.

Copy link

codecov bot commented Oct 16, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@dmurphy18 dmurphy18 merged commit 8e3921d into salt-extensions:main Oct 17, 2024
18 checks passed
@dmurphy18
Copy link
Contributor Author

Will be able to remove cryptography as a dependency once saltstack/salt#66977 is merged, if desire to only work with Salt 2006.10 and above, when it is released

@dmurphy18 dmurphy18 changed the title Update from copier using template 0.5.1 Update from copier using template 0.5.2 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants