Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded paths prevent parallel execution #44

Open
aozalevsky opened this issue May 5, 2022 · 1 comment
Open

Hardcoded paths prevent parallel execution #44

aozalevsky opened this issue May 5, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@aozalevsky
Copy link
Contributor

It would be nice to have the ability to update the PDB-Dev in parallel. Together with the recent updates in #38 it would allow to rebuild the whole repo (with recalculated values) in under 2 minutes on a modern 32-128 core node.

So far I identified several places which interfere with parallel execution:

if os.path.isfile('test.cif'):
os.remove('test.cif')
file_re = open('test.cif', 'w')

uses a hardcoded test.cif as a temporary filename

def clean_all():
'''
delete all generated files
'''
# dirname_ed = os.getcwd()
os.listdir('.')
for item in os.listdir('.'):
if item.endswith('.txt'):
os.remove(item)
if item.endswith('.csv'):
os.remove(item)
if item.endswith('.json'):
os.remove(item)
if item.endswith('.sascif'):
os.remove(item)

removes any temp files by mask, including temp files generated for other structures. It specifically hits sascif processing (looks like other files are not reread again. at least when molprobity and excluded volume are already recalculated).

with open(code+'.json', 'w') as f:

with open(code+'.sascif', 'w') as f:

fname = key+str(fitnum)+'fit.csv'
with open(fname, 'w') as f:
f.write(fit.text)

fit_1.to_csv('fit1.csv', header=False, index=False)

fit_2.to_csv('fit2.csv', header=False, index=False)
f1 = open('pval.txt', 'w+')

temp files for sas processing.

@aozalevsky aozalevsky added the enhancement New feature or request label May 9, 2022
@aozalevsky
Copy link
Contributor Author

Fully addressed in v2.0. Keeping open until the merge.

@aozalevsky aozalevsky added this to the v2.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant