From 0295ffbd47046c48bff86bdcd3609c3e53d84709 Mon Sep 17 00:00:00 2001 From: Jonatan Witoszek Date: Wed, 15 Jan 2025 16:28:39 +0100 Subject: [PATCH 1/2] Add release notes for upcoming Adyen release --- .../app-store/apps/adyen/migration-guides.mdx | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/docs/developer/app-store/apps/adyen/migration-guides.mdx b/docs/developer/app-store/apps/adyen/migration-guides.mdx index 73c03f7fe..9831e7d78 100644 --- a/docs/developer/app-store/apps/adyen/migration-guides.mdx +++ b/docs/developer/app-store/apps/adyen/migration-guides.mdx @@ -12,6 +12,50 @@ some functional changes may be breaking. Below is the list of changes introduced in Adyen App releases +## v.1.x.x + +### New features + +- Added client logs to following webhooks. Thanks to this stores that use Adyen app will have better observability on what is going inside the app. + - `transaction-process-session` + - `transaction-refund-requested` + - `transaction-charge-requested` + - `transaction-cancel-requested` + - Adyen webhook + +### CANCELATION webhook improvements + +#### Before this release + +Previously when handling [`CANCELLATION`](https://docs.adyen.com/api-explorer/Webhooks/1/post/CANCELLATION) webhook events from Adyen that didn't have `amount` field, +app sent `amount: 0` to Saleor, which caused Transactions that were cancelled in Adyen to still have `authorizedAmount`, when they should have had `authorizedAmount: 0` and `cancelledAmount`. + +#### After this release + +Now app when handling such events, will fetch last known `CANCEL_*` event from Saleor and use it's amount or will use `authorizedAmount` or `authorizePendingAmount` on related `TransactionItem` from Saleor. + +### Incorrect handling of negative amounts + +#### Before this release + +Previously app could have use a `TransactionEvent` with `amount` that was lower than zero, due to incorrect comparison. +This would have caused events reported to be incorrect and possibly breaking Saleor calculations. + +#### After this release + +This would have caused events reported to be incorrect and possibly breaking Saleor calculations. + +### Improved Apple Pay timeout handling + +#### Before this release + +Previously Apple Pay related requests had **20s timeout**. This caused sync webhooks to timeout and because of that Saleor ignored app's response. + +#### After this release + +After this change app will use 18s timeout, so that it has an error margin for sending the actual response to Saleor. + + ## v.1.4.3 In this release a new feature was added: when making payments app will send [ESD (Enhanced Scheme Details) Level 2 data](https://docs.adyen.com/payment-methods/cards/enhanced-scheme-data/l2-l3/#include-level-2-3-esd-in-your-request) to Adyen. From a239ddc97829458c6702c8ded703f274bf3f1a8e Mon Sep 17 00:00:00 2001 From: Jonatan Witoszek Date: Wed, 15 Jan 2025 16:33:34 +0100 Subject: [PATCH 2/2] Improve wording --- .../app-store/apps/adyen/migration-guides.mdx | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/docs/developer/app-store/apps/adyen/migration-guides.mdx b/docs/developer/app-store/apps/adyen/migration-guides.mdx index 9831e7d78..9a6d6e13b 100644 --- a/docs/developer/app-store/apps/adyen/migration-guides.mdx +++ b/docs/developer/app-store/apps/adyen/migration-guides.mdx @@ -16,7 +16,7 @@ Below is the list of changes introduced in Adyen App releases ### New features -- Added client logs to following webhooks. Thanks to this stores that use Adyen app will have better observability on what is going inside the app. +- The app now includes client logs for enhanced observability in the following webhooks: - `transaction-process-session` - `transaction-refund-requested` - `transaction-charge-requested` @@ -27,8 +27,11 @@ Below is the list of changes introduced in Adyen App releases #### Before this release -Previously when handling [`CANCELLATION`](https://docs.adyen.com/api-explorer/Webhooks/1/post/CANCELLATION) webhook events from Adyen that didn't have `amount` field, -app sent `amount: 0` to Saleor, which caused Transactions that were cancelled in Adyen to still have `authorizedAmount`, when they should have had `authorizedAmount: 0` and `cancelledAmount`. +Previously when handling [`CANCELLATION`](https://docs.adyen.com/api-explorer/Webhooks/1/post/CANCELLATION) webhook events from Adyen that didn't have `amount` value, +app sent `amount: 0 to` Saleor, which caused Transactions that were cancelled in Adyen to still have `authorizedAmount`, when they should have had: + +- `authorizedAmount`: `0` +- `cancelledAmount`: previous authorized amount #### After this release @@ -38,12 +41,12 @@ Now app when handling such events, will fetch last known `CANCEL_*` event from S #### Before this release -Previously app could have use a `TransactionEvent` with `amount` that was lower than zero, due to incorrect comparison. -This would have caused events reported to be incorrect and possibly breaking Saleor calculations. +Previously the app could use a `TransactionEvent` with `amount` that was lower than zero, due to incorrect comparison. +This would cause events to be reported incorrectly and potentially break Saleor calculations. #### After this release -This would have caused events reported to be incorrect and possibly breaking Saleor calculations. +The app now properly validates amount values, ensuring all transaction events use correct positive amounts in calculations. ### Improved Apple Pay timeout handling @@ -55,7 +58,6 @@ Previously Apple Pay related requests had **20s timeout**. This caused sync webh After this change app will use 18s timeout, so that it has an error margin for sending the actual response to Saleor. - ## v.1.4.3 In this release a new feature was added: when making payments app will send [ESD (Enhanced Scheme Details) Level 2 data](https://docs.adyen.com/payment-methods/cards/enhanced-scheme-data/l2-l3/#include-level-2-3-esd-in-your-request) to Adyen.